Re: [PATCH v5 3/3] platform/chrome: Register cros_ec_accel_legacy driver

From: Lee Jones
Date: Thu Dec 07 2017 - 04:31:35 EST


On Fri, 01 Dec 2017, Gwendal Grignou wrote:

> Checked against 3bf98755f9c670c5c10ca05cba22848d65117cb2 (CHROMIUM:
> iio: accel: Add cros_ec_accel_legacy driver)
>
> Fixup f2b141a242e59017dbc774dc916748670a41da0b (FIXUP: CHROMIUM: iio:
> accel: Add cros_ec_accel_legacy driver) is required for devices with
> secondary Embedded Controllers.

Is that an Ack or a NAck?

And pleeeeeease don't top post.

> On Fri, Dec 1, 2017 at 5:42 AM, Thierry Escande
> <thierry.escande@xxxxxxxxxxxxx> wrote:
> > With this patch, the cros_ec_ctl driver will register the legacy
> > accelerometer driver (named cros_ec_accel_legacy) if it fails to
> > register sensors through the usual path cros_ec_sensors_register().
> > This legacy device is present on Chromebook devices with older EC
> > firmware only supporting deprecated EC commands (Glimmer based devices).
> >
> > Signed-off-by: Thierry Escande <thierry.escande@xxxxxxxxxxxxx>
> > ---
> > drivers/mfd/cros_ec_dev.c | 53 +++++++++++++++++++++++++++++++++++++++++++++++
> > 1 file changed, 53 insertions(+)

[...]

--
Lee Jones
Linaro Services Technical Lead
Linaro.org â Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog