Re: [PATCH V2] netlink: Add netns check on taps

From: David Miller
Date: Wed Dec 06 2017 - 15:57:23 EST


From: Kevin Cernekee <cernekee@xxxxxxxxxxxx>
Date: Wed, 6 Dec 2017 12:12:27 -0800

> Currently, a nlmon link inside a child namespace can observe systemwide
> netlink activity. Filter the traffic so that nlmon can only sniff
> netlink messages from its own netns.
>
> Test case:
>
> vpnns -- bash -c "ip link add nlmon0 type nlmon; \
> ip link set nlmon0 up; \
> tcpdump -i nlmon0 -q -w /tmp/nlmon.pcap -U" &
> sudo ip xfrm state add src 10.1.1.1 dst 10.1.1.2 proto esp \
> spi 0x1 mode transport \
> auth sha1 0x6162633132330000000000000000000000000000 \
> enc aes 0x00000000000000000000000000000000
> grep --binary abc123 /tmp/nlmon.pcap
>
> Signed-off-by: Kevin Cernekee <cernekee@xxxxxxxxxxxx>

Applied and queued up for -stable, thanks Kevin.