Re: [PATCH] x86/mm/kaiser: avoid 32-bit/PAE build warning

From: Dave Hansen
Date: Wed Dec 06 2017 - 10:09:04 EST


On 12/06/2017 07:03 AM, Arnd Bergmann wrote:
> On Wed, Dec 6, 2017 at 3:15 PM, Arnd Bergmann <arnd@xxxxxxxx> wrote:
>
>> This changes the type to u64 in the architecture-independent dummy,
>> and to pteval_t in the x86 specific portion that is used when KAISER
>> is enabled, ensuring that the flags can always fit. Unfortunately,
>> pteval_t is not provided by most other architectures, so we are
>> a little bit inconsistent here.
>
> I ran into a new regression with my patch applied, after doing more randconfig
> builds:
>
> In file included from /git/arm-soc/include/linux/kaiser.h:5,
> from /git/arm-soc/arch/x86/events/intel/ds.c:4:
> arch/x86/include/asm/kaiser.h:34:10: error: unknown type name
> 'pteval_t'; did you mean 'dev_t'?
>
> Maybe it's better to just to the last one-line change in include/linux/kaiser.h.

Hi Arnd,

Are you hitting this in -next?

The newest version of this code has a single kpti_init() function that
shouldn't have any of these problems.