Re: [PATCH] ACPI / GED: unregister interrupts during shutdown

From: Rafael J. Wysocki
Date: Wed Dec 06 2017 - 08:37:38 EST


On Wed, Dec 6, 2017 at 2:24 PM, Sinan Kaya <okaya@xxxxxxxxxxxxxx> wrote:
> On 12/5/2017 5:18 PM, Rafael J. Wysocki wrote:
>> On Tue, Dec 5, 2017 at 10:01 PM, Sinan Kaya <okaya@xxxxxxxxxxxxxx> wrote:
>>> Some GED interrupts could be pending by the time we are doing a reboot.

[cut]

>
>>
>>> .probe = ged_probe,
>>> .driver = {
>>> .name = MODULE_NAME,
>>> --
>>
>> Overall, it looks like we should just unbind the driver from all
>> devices on shutdown.
>
> I see that shutdown is getting called on all GED instances. That should
> take care of it, right?

Yes, it should, so I'm not sure why you need the list in the first place.

Also it looks like something along the lines of devres_release_all()
should be sufficient.

Thanks,
Rafael