Re: [PATCH] USB: emi26: Delete an error message for a failed memory allocation in emi26_writememory()

From: SF Markus Elfring
Date: Wed Dec 06 2017 - 08:25:20 EST


>> @@ -42,10 +42,9 @@ static int emi26_writememory (struct usb_device *dev, int address,
>> int result;
>> unsigned char *buffer = kmemdup(data, length, GFP_KERNEL);
>>
>> - if (!buffer) {
>> - dev_err(&dev->dev, "kmalloc(%d) failed.\n", length);
>
> I guess the length information would not be so easy to find in the backtrace.

Why do you âguessâ?


>> + if (!buffer)
>> return -ENOMEM;
>> - }

Would we like to achieve another consensus on the data which are provided by
a default Linux allocation failure report?

Regards,
Markus