Re: [PATCH v4 00/73] XArray version 4

From: Matthew Wilcox
Date: Tue Dec 05 2017 - 21:27:23 EST


On Wed, Dec 06, 2017 at 01:17:52PM +1100, Dave Chinner wrote:
> On Wed, Dec 06, 2017 at 01:53:41AM +0000, Matthew Wilcox wrote:
> > Huh, you've caught a couple of problems that 0day hasn't sent me yet. Try turning on DAX or TRANSPARENT_HUGEPAGE. Thanks!
>
> Dax is turned on, CONFIG_TRANSPARENT_HUGEPAGE is not.
>
> Looks like nothing is setting CONFIG_RADIX_TREE_MULTIORDER, which is
> what xas_set_order() is hidden under.
>
> Ah, CONFIG_ZONE_DEVICE turns it on, not CONFIG_DAX/CONFIG_FS_DAX.
>
> Hmmmm. That seems wrong if it's used in fs/dax.c...

Yes, it's my mistake for not making xas_set_order available in the
!MULTIORDER case. I'm working on a fix now.

> What a godawful mess Kconfig has turned into.

I'm not going to argue with that ...