Re: [PATCH v3 02/15] NTB: Set dma mask and dma coherent mask to NTB devices

From: Logan Gunthorpe
Date: Tue Dec 05 2017 - 18:39:14 EST




On 05/12/17 03:39 PM, Serge Semin wrote:
The dma_mask and dma_coherent_mask fields of the NTB struct device
weren't initialized in hardware drivers. In fact it should be done
instead of PCIe interface usage, since NTB clients are supposed to
use NTB API and left unaware of real hardware implementation.
In addition to that ntb_device_register() method shouldn't clear
the passed ntb_dev structure, since it dma_mask is initialized
by hardware drivers.

I think you still need to address my comments in the previous version. As best as I can see this patch does nothing.

Logan