Re: [PATCH] scripts/faddr2line: extend usage on generic arch

From: Richard Weinberger
Date: Tue Dec 05 2017 - 16:30:56 EST


On Tue, Nov 21, 2017 at 10:29 AM, Liu, Changcheng
<changcheng.liu@xxxxxxxxx> wrote:
> fadd2line script should use the binary tool
> used for the target system.
>
> Signed-off-by: Liu Changcheng <changcheng.liu@xxxxxxxxx>
>
> diff --git a/scripts/faddr2line b/scripts/faddr2line
> index 1f5ce95..39e07d8 100755
> --- a/scripts/faddr2line
> +++ b/scripts/faddr2line
> @@ -44,9 +44,16 @@
> set -o errexit
> set -o nounset
>
> +READELF="${CROSS_COMPILE}readelf"
> +ADDR2LINE="${CROSS_COMPILE}addr2line"
> +SIZE="${CROSS_COMPILE}size"
> +NM="${CROSS_COMPILE}nm"

How is this supposed to work when not cross compiling?
When CROSS_COMPILE is not set this script will terminate because of
the "set -o nounset" bash setting...

--
Thanks,
//richard