Re: [PATCH] checkpatch: warn for use of %px

From: Tobin C. Harding
Date: Tue Dec 05 2017 - 15:27:34 EST


On Tue, Dec 05, 2017 at 07:27:18AM -0800, Joe Perches wrote:
> On Tue, 2017-12-05 at 20:44 +1100, Tobin C. Harding wrote:
> > On Mon, Dec 04, 2017 at 11:24:24PM -0800, Joe Perches wrote:
> > > On Tue, 2017-12-05 at 08:17 +1100, Tobin C. Harding wrote:
> > > > Usage of the new %px specifier potentially leaks sensitive
> > > > inforamtion. Printing kernel addresses exposes the kernel layout in
> > >
> > > information
>
> > I don't understand this comment? Do you mean the wording is wrong?
> > I'll re-word as suggested below.
>
> It's just a spelling typo correction.

ha ha, note to self - be careful doing kernel email late at night :)

> []
> > > > Suggested-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
> > > > Signed-off-by: Tobin C. Harding <me@xxxxxxxx>
> > > > Co-Developed-by: Joe Perches <joe@xxxxxxxxxxx>
> > > > Are you happy with this tagging? Needs your signed-off-by still.
>
> I think signatures tags are pretty freeform and
> I'm not particularly concerned about them.
>
> I think Andrew Morton may object and change it
> or remove it. Have an:
>
> Acked-by: Joe Perches <joe@xxxxxxxxxxx>

Cool, will add and re-spin

thanks,
Tobin.