Re: [PATCH 5/7] ntb_hw_switchtec: Expand PFF CSR registers

From: Logan Gunthorpe
Date: Tue Dec 05 2017 - 14:40:40 EST




On 05/12/17 12:12 PM, Jon Mason wrote:
It sucks that we don't already have a struct for PCI config space we
can reuse here. If you find the time, it would be good to add in the
future to reduce duplicate code here and in the PCI core. However,
this patch is fine without it.

I agree. And believe me I looked for one. I'm not sure if it makes sense to add it to general code at this time when I'm the only user.

Logan