Re: [PATCH v3 11/14] nubus: Rename struct nubus_dev

From: Bartlomiej Zolnierkiewicz
Date: Tue Dec 05 2017 - 08:50:56 EST


On Tuesday, December 05, 2017 01:20:02 AM Finn Thain wrote:
> It is misleading to call a functional resource a "device". In adopting
> the Linux Driver Model, the struct device will be embedded in struct
> nubus_board. That will compound the terminlogy problem because drivers
> will bind with boards, not with functional resources. Avoid this by
> renaming struct nubus_dev as struct nubus_rsrc. "Functional resource"
> is the vendor's terminology so this helps avoid confusion.
>
> Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@xxxxxxxxxxx>
> Tested-by: Stan Johnson <userm57@xxxxxxxxx>
> Signed-off-by: Finn Thain <fthain@xxxxxxxxxxxxxxxxxxx>

Acked-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@xxxxxxxxxxx>

for fbdev part

> ---
> drivers/net/ethernet/8390/mac8390.c | 26 ++++----
> drivers/net/ethernet/natsemi/macsonic.c | 22 +++----
> drivers/nubus/nubus.c | 105 ++++++++++++++++----------------
> drivers/nubus/proc.c | 15 ++---
> drivers/video/fbdev/macfb.c | 2 +-
> include/linux/nubus.h | 30 +++++----
> 6 files changed, 98 insertions(+), 102 deletions(-)

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics