Re: [patch 22/60] x86/entry: Clean up the SYSENTER_stack code

From: Borislav Petkov
Date: Mon Dec 04 2017 - 14:42:01 EST


On Mon, Dec 04, 2017 at 03:07:28PM +0100, Thomas Gleixner wrote:
> From: Andy Lutomirski <luto@xxxxxxxxxx>
>
> The existing code was a mess, mainly because C arrays are nasty. Turn
> SYSENTER_stack into a struct, add a helper to find it, and do all the
> obvious cleanups this enables.
>
> Signed-off-by: Andy Lutomirski <luto@xxxxxxxxxx>
> Signed-off-by: Ingo Molnar <mingo@xxxxxxxxxx>
> Signed-off-by: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
> Reviewed-by: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
> Cc: Rik van Riel <riel@xxxxxxxxxx>
> Cc: Denys Vlasenko <dvlasenk@xxxxxxxxxx>
> Cc: Peter Zijlstra <peterz@xxxxxxxxxxxxx>
> Cc: Brian Gerst <brgerst@xxxxxxxxx>
> Cc: Dave Hansen <dave.hansen@xxxxxxxxxxxxxxx>
> Cc: Josh Poimboeuf <jpoimboe@xxxxxxxxxx>
> Cc: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>
> Link: https://lkml.kernel.org/r/38ff640712c9b591b32de24a080daf13afaba234.1511497875.git.luto@xxxxxxxxxx
>
> ---
> arch/x86/entry/entry_32.S | 4 ++--
> arch/x86/entry/entry_64.S | 2 +-
> arch/x86/include/asm/fixmap.h | 5 +++++
> arch/x86/include/asm/processor.h | 6 +++++-
> arch/x86/kernel/asm-offsets.c | 6 ++----
> arch/x86/kernel/cpu/common.c | 14 +++-----------
> arch/x86/kernel/dumpstack.c | 7 +++----
> 7 files changed, 21 insertions(+), 23 deletions(-)

Reviewed-by: Borislav Petkov <bp@xxxxxxx>

--
Regards/Gruss,
Boris.

SUSE Linux GmbH, GF: Felix ImendÃrffer, Jane Smithard, Graham Norton, HRB 21284 (AG NÃrnberg)
--