Re: [PATCH tip/core/rcu 05/10] workqueue: Eliminate cond_resched_rcu_qs() in favor of cond_resched()

From: Paul E. McKenney
Date: Mon Dec 04 2017 - 13:28:46 EST


On Sat, Dec 02, 2017 at 09:06:29AM +0800, Lai Jiangshan wrote:
> On Sat, Dec 2, 2017 at 3:21 AM, Paul E. McKenney
> <paulmck@xxxxxxxxxxxxxxxxxx> wrote:
> > Now that cond_resched() also provides RCU quiescent states when
> > needed, it can be used in place of cond_resched_rcu_qs(). This
> > commit therefore makes this change.
> >
> > Signed-off-by: Paul E. McKenney <paulmck@xxxxxxxxxxxxxxxxxx>
> > Cc: Tejun Heo <tj@xxxxxxxxxx>
> > Cc: Lai Jiangshan <jiangshanlai@xxxxxxxxx>
>
> Reviewed-by: Lai Jiangshan <jiangshanlai@xxxxxxxxx>

Applied, thank you for the review!

Thanx, Paul

> > ---
> > kernel/workqueue.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/kernel/workqueue.c b/kernel/workqueue.c
> > index 8fdb710bfdd7..aee7eaab05cb 100644
> > --- a/kernel/workqueue.c
> > +++ b/kernel/workqueue.c
> > @@ -2135,7 +2135,7 @@ __acquires(&pool->lock)
> > * stop_machine. At the same time, report a quiescent RCU state so
> > * the same condition doesn't freeze RCU.
> > */
> > - cond_resched_rcu_qs();
> > + cond_resched();
> >
> > spin_lock_irq(&pool->lock);
> >
> > --
> > 2.5.2
> >
>