Re: [PATCH] ext4: Support fast symlinks from ext3 file systems

From: Theodore Ts'o
Date: Sun Dec 03 2017 - 22:49:48 EST


On Mon, Nov 27, 2017 at 11:08:53AM -0700, Andreas Dilger wrote:
> On Nov 27, 2017, at 10:37 AM, Andi Kleen <andi@xxxxxxxxxxxxxx> wrote:
> >
> > From: Andi Kleen <ak@xxxxxxxxxxxxxxx>
> >
> > dbb3c27f5b91c4 (ext4: change fast symlink test to not rely on i_blocks)
> > broke ~10 years old ext3 file systems created by 2.6.17. Any ELF
> > executable fails because the /lib/ld-linux.so.2 fast symlink
> > cannot be read anymore.
> >
> > The patch assumed fast symlinks were created in a specific way,
> > but that's not true on these really old file systems.
> >
> > The new behavior is apparently needed only with the large EA inode
> > feature.
> >
> > Revert to the old behavior if the large EA inode feature is not set.
> >
> > This makes my old VM boot again.
> >
> > Fixes: dbb3c27f5b91c4 (ext4: change fast symlink test to not rely ...)
> > Signed-off-by: Andi Kleen <ak@xxxxxxxxxxxxxxx>
>
> Reviewed-by: Andreas Dilger <adilger@xxxxxxxxx>

Thanks, applied.

- Ted