Re: [PATCH v5 04/12] perf util: Add rbtree node_delete ops

From: Andi Kleen
Date: Fri Dec 01 2017 - 13:29:44 EST


On Fri, Dec 01, 2017 at 11:14:52AM -0300, Arnaldo Carvalho de Melo wrote:
> Em Fri, Dec 01, 2017 at 06:57:28PM +0800, Jin Yao escreveu:
> > @@ -130,7 +140,7 @@ void perf_stat__init_shadow_stats(void)
> > rblist__init(&runtime_saved_values);
> > runtime_saved_values.node_cmp = saved_value_cmp;
> > runtime_saved_values.node_new = saved_value_new;
> > - /* No delete for now */
> > + runtime_saved_values.node_delete = saved_value_delete;
> > }
>
> Andi, was some reason behind that comment, is it safe to add it now?

It is safe to add.