Re: [PATCH 21/21] x86/entry: Clean up the SYSENTER_stack code

From: Borislav Petkov
Date: Fri Dec 01 2017 - 13:00:01 EST


On Mon, Nov 27, 2017 at 11:45:29AM +0100, Ingo Molnar wrote:
> diff --git a/arch/x86/include/asm/fixmap.h b/arch/x86/include/asm/fixmap.h
> index 81fdc405ab1f..5a1013df456e 100644
> --- a/arch/x86/include/asm/fixmap.h
> +++ b/arch/x86/include/asm/fixmap.h
> @@ -237,5 +237,10 @@ static inline struct cpu_entry_area *get_cpu_entry_area(int cpu)
> return (struct cpu_entry_area *)__fix_to_virt(__get_cpu_entry_area_page_index(cpu, 0));
> }
>
> +static inline struct SYSENTER_stack *cpu_SYSENTER_stack(int cpu)
> +{
> + return &get_cpu_entry_area((cpu))->tss.SYSENTER_stack;
^^^^^^^^^
Those inner brackets are not needed, right?

--
Regards/Gruss,
Boris.

Good mailing practices for 400: avoid top-posting and trim the reply.