Re: [PATCH] pci: dwc: pci-dra7xx: Make shutdown handler static

From: Keerthy
Date: Fri Dec 01 2017 - 00:14:06 EST




On Friday 01 December 2017 10:36 AM, Vignesh R wrote:
> Declare dra7xx_pcie_shutdown() as a static function as its not used
> elsewhere.

Seems like the below version that had static version was not taken:

https://patchwork.kernel.org/patch/10052579/

So for this patch:

Reviewed-by: Keerthy <j-keerthy@xxxxxx>

>
> Signed-off-by: Vignesh R <vigneshr@xxxxxx>
> ---
> drivers/pci/dwc/pci-dra7xx.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pci/dwc/pci-dra7xx.c b/drivers/pci/dwc/pci-dra7xx.c
> index 59e8de34cec6..b9db442af793 100644
> --- a/drivers/pci/dwc/pci-dra7xx.c
> +++ b/drivers/pci/dwc/pci-dra7xx.c
> @@ -815,7 +815,7 @@ static int dra7xx_pcie_resume_noirq(struct device *dev)
> }
> #endif
>
> -void dra7xx_pcie_shutdown(struct platform_device *pdev)
> +static void dra7xx_pcie_shutdown(struct platform_device *pdev)
> {
> struct device *dev = &pdev->dev;
> struct dra7xx_pcie *dra7xx = dev_get_drvdata(dev);
>