Re: [PATCH 01/08] NTB: ntb_test: Safely use paths with whitespace

From: Logan Gunthorpe
Date: Thu Nov 30 2017 - 17:04:44 EST


Hey,

I took a cursory look at this series and it largely looks good to me. Nice work. If I have time in the next couple days I'll do a more thorough review. However, does the series not depend on changes to ntb_tool? It would have been good to include a cover letter describing the intention/plan.


On 30/11/17 02:42 PM, Serge Semin wrote:
If some of variables like LOC/REM or LOCAL_*/REMOTE_* got
whitespaces, the script may fail with syntax error.

Signed-off-by: Serge Semin <fancer.lancer@xxxxxxxxx>

Seeing this is a bug fix I Ack Patch 1 and suggest it get merged ahead of the series.

Acked-by: Logan Gunthorpe <logang@xxxxxxxxxxxx>
Fixes: a9c59ef77458 ("ntb_test: Add a selftest script for the NTB subsystem")

Thanks for the fix.

Logan