Re: [patches] Re: [PATCH] riscv/ftrace: Add basic support

From: Palmer Dabbelt
Date: Thu Nov 30 2017 - 14:09:30 EST


On Thu, 30 Nov 2017 03:31:53 PST (-0800), pombredanne@xxxxxxxx wrote:
On Thu, Nov 30, 2017 at 9:53 AM, Alan Kao <nonerkao@xxxxxxxxx> wrote:
[]
diff --git a/arch/riscv/include/asm/ftrace.h b/arch/riscv/include/asm/ftrace.h
new file mode 100644
index 000000000000..38beadb07ad5
--- /dev/null
+++ b/arch/riscv/include/asm/ftrace.h
@@ -0,0 +1,23 @@
+/*
+ * Copyright (C) 2017 Andes Technology Corporation
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program. If not, see <http://www.gnu.org/licenses/>.
+ */

You may want to use the new SPDX ids here instead?
e.g.
+// SPDX-License-Identifer: GPL-2.0
+// Copyright (C) 2017 Andes Technology Corporation

Neater and simpler?
See Linus posts on the topic of comment styles too BTW

I believe we need to convert all the RISC-V stuff to SPDX headers, that change happened between when we got the port reviewed and made it into Linus' tree. Do you happen to know if there's some script I can run to do this automatically?