Re: [PATCH] x86/power: Fix some ordering bugs in __restore_processor_context()

From: Thomas Gleixner
Date: Thu Nov 30 2017 - 11:01:02 EST


On Thu, 30 Nov 2017, Andy Lutomirski wrote:

> On Thu, Nov 30, 2017 at 7:57 AM, Andy Lutomirski <luto@xxxxxxxxxx> wrote:
> > __restore_processor_context() had a couple of ordering bugs. It
> > restored GSBASE after calling load_gs_index(), and the latter can
> > call into tracing code. It also tried to restore segment registers
> > before restoring the LDT, which is straight-up wrong.
>
> Ingo, Thomas, if you apply this version, can you fix up the following
> changelog bug:
>
> > .seg_not_present = 1,
>
> That should be = 0 above.

Sure. I'll wait for Jarkko to confirm.

> If I send a v2, I'll fix it.
>