Re: [PATCH] usbip: Fix USB device hang due to wrong enabling of scatter-gather

From: Shuah Khan
Date: Thu Nov 30 2017 - 10:00:38 EST


On 11/29/2017 07:22 PM, Yuyang Du wrote:
> The previous USB3 SuperSpeed enabling patches mistakenly enabled
> URB scatter-gather chaining, which is actually not supported by
> the VHCI HCD. This patch fixes that.
>
> Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=197867
> Fixes: 03cd00d538a6feb ("usbip: vhci-hcd: Set the vhci structure up to work")
> Reported-by: Juan Zea <juan.zea@xxxxxxxxxx>
> Signed-off-by: Yuyang Du <yuyang.du@xxxxxxxxx>> ---
> drivers/usb/usbip/vhci_hcd.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/usb/usbip/vhci_hcd.c b/drivers/usb/usbip/vhci_hcd.c
> index 713e941..6b3278c 100644
> --- a/drivers/usb/usbip/vhci_hcd.c
> +++ b/drivers/usb/usbip/vhci_hcd.c
> @@ -1098,7 +1098,6 @@ static int hcd_name_to_id(const char *name)
> static int vhci_setup(struct usb_hcd *hcd)
> {
> struct vhci *vhci = *((void **)dev_get_platdata(hcd->self.controller));
> - hcd->self.sg_tablesize = ~0;
> if (usb_hcd_is_primary_hcd(hcd)) {
> vhci->vhci_hcd_hs = hcd_to_vhci_hcd(hcd);
> vhci->vhci_hcd_hs->vhci = vhci;
>

This need to go into stable as well. It applies to 4.14

Acked-by: Shuah Khan <shuahkh@xxxxxxxxxxxxxxx>

thanks,
-- Shuah