Re: [PATCH] mmc: block: make function mmc_cqe_issue_type static

From: Adrian Hunter
Date: Thu Nov 30 2017 - 06:45:35 EST


On 30/11/17 13:37, Colin King wrote:
> From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
>
> The function mmc_cqe_issue_type is local to the source and does
> not need to be in global scope, so make it static.
>
> Cleans up sparse warning:
> drivers/mmc/core/queue.c:62:21: warning: symbol 'mmc_cqe_issue_type'
> was not declared. Should it be static?
>
> Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>

Acked-by: Adrian Hunter <adrian.hunter@xxxxxxxxx>

> ---
> drivers/mmc/core/queue.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mmc/core/queue.c b/drivers/mmc/core/queue.c
> index d8394007bc99..5db388081789 100644
> --- a/drivers/mmc/core/queue.c
> +++ b/drivers/mmc/core/queue.c
> @@ -59,8 +59,8 @@ static inline bool mmc_cqe_can_dcmd(struct mmc_host *host)
> return host->caps2 & MMC_CAP2_CQE_DCMD;
> }
>
> -enum mmc_issue_type mmc_cqe_issue_type(struct mmc_host *host,
> - struct request *req)
> +static enum mmc_issue_type mmc_cqe_issue_type(struct mmc_host *host,
> + struct request *req)
> {
> switch (req_op(req)) {
> case REQ_OP_DRV_IN:
>