Re: [PATCH v3] doc: add maintainer book

From: Mauro Carvalho Chehab
Date: Thu Nov 30 2017 - 06:06:46 EST


Em Thu, 30 Nov 2017 21:47:44 +1100
"Tobin C. Harding" <me@xxxxxxxx> escreveu:

> On Thu, Nov 30, 2017 at 07:01:19AM -0200, Mauro Carvalho Chehab wrote:
> > Em Thu, 30 Nov 2017 12:55:07 +1100
> > "Tobin C. Harding" <me@xxxxxxxx> escreveu:


> > > +So, by way of an example, Greg gives; a pull request with miscellaneous
> >
> > Nitpick: there's an extra ";" character above:
> > gives; -> gives
>
> Ha ha, I thought for ages how to word this bit. The irony of grammar
> corrections from a non-native speaker is not lost on me :)

:-)

Well, if that serves as a consolation, I had to go to a dictionary to
understand "By way of":

https://www.collinsdictionary.com/dictionary/english/by-way-of

As that was a new expression for me :-)

Anyway, AFAIKT, English and Portuguese (and probably Spanish) have
similar rules with regards to commas and semicolons.

>
> Perhaps:
>
> By way of an example Greg gives, a pull request with miscellaneous
>
> I'll take any nitpicks you have Mauro, striving for perfection here. Thanks.

Yeah, that looks a way better on my eyes.

Thanks,
Mauro