Re: [PATCH] leds: pm8058: Make ledtype pointer sized type

From: Lee Jones
Date: Thu Nov 30 2017 - 04:41:58 EST


On Thu, 30 Nov 2017, Linus Walleij wrote:

> On Thu, Nov 30, 2017 at 4:05 AM, Bjorn Andersson
> <bjorn.andersson@xxxxxxxxxx> wrote:
>
> > The pointer returned by of_device_get_match_data() doesn't have the same
> > size as u32 on 64-bit architectures, causing issues when compile testing
> > the driver on such platform. Make ledtype unsigned long instead, to
> > solve this problem.
> >
> > Fixes: 7f866986e705 ("leds: add PM8058 LEDs driver")
> > Cc: Linus Walleij <linus.walleij@xxxxxxxxxx>
> > Signed-off-by: Bjorn Andersson <bjorn.andersson@xxxxxxxxxx>
>
> Thanks for covering my ass.

:D

> Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx>

I still need a LED Ack if I'm going to take this.

--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org â Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog