Re: [PATCH 1/2] f2fs: pass down write hints to block layer for bufferd write

From: Chao Yu
Date: Thu Nov 30 2017 - 02:06:56 EST


Hi Hyunchul,

On 2017/11/28 8:23, Hyunchul Lee wrote:
> From: Hyunchul Lee <cheol.lee@xxxxxxx>
>
> This implements which hint is passed down to block layer
> for datas from the specific segment type.
>
> segment type hints
> ------------ -----
> COLD_NODE & COLD_DATA WRITE_LIFE_EXTREME
> WARM_DATA WRITE_LIFE_NONE
> HOT_NODE & WARM_NODE WRITE_LIFE_LONG
> HOT_DATA WRITE_LIFE_MEDIUM
> META_DATA WRITE_LIFE_SHORT

Just noticed, if our user do not give the hint via ioctl, f2fs can
provider hint to lower layer according to hot/cold separation ability,
it will be okay. But once user give his hint which may be more accurate
than filesystem, hint converted by f2fs may be wrong.

So what do you think of adding an option to control whether filesystem
can convert hint user given?

Thanks,