Re: [PATCH resend] mm/page_alloc: fix comment is __get_free_pages

From: Michal Hocko
Date: Wed Nov 29 2017 - 11:04:53 EST


On Mon 27-11-17 12:33:41, Michal Hocko wrote:
> On Mon 27-11-17 19:09:24, JianKang Chen wrote:
> > From: Jiankang Chen <chenjiankang1@xxxxxxxxxx>
> >
> > __get_free_pages will return an virtual address,
> > but it is not just 32-bit address, for example a 64-bit system.
> > And this comment really confuse new bigenner of mm.
>
> s@bigenner@beginner@
>
> Anyway, do we really need a bug on for this? Has this actually caught
> any wrong usage? VM_BUG_ON tends to be enabled these days AFAIK and
> panicking the kernel seems like an over-reaction. If there is a real
> risk then why don't we simply mask __GFP_HIGHMEM off when calling
> alloc_pages?

I meant this
---