Re: [PATCH v3 2/3] clk: meson-axg: add clock controller drivers

From: Yixun Lan
Date: Tue Nov 28 2017 - 18:17:10 EST




HI Rob

On 11/29/17 00:30, Rob Herring wrote:
> On Tue, Nov 28, 2017 at 08:53:29PM +0800, Yixun Lan wrote:
>> From: Qiufang Dai <qiufang.dai@xxxxxxxxxxx>
>>
>> Add clock controller drivers for Amlogic Meson-AXG SoC.
>>
>> Signed-off-by: Qiufang Dai <qiufang.dai@xxxxxxxxxxx>
>> Signed-off-by: Yixun Lan <yixun.lan@xxxxxxxxxxx>
>> ---
>> arch/arm64/Kconfig.platforms | 1 +
>> drivers/clk/meson/Kconfig | 8 +
>> drivers/clk/meson/Makefile | 1 +
>> drivers/clk/meson/axg.c | 948 +++++++++++++++++++++++++++++++++++
>> drivers/clk/meson/axg.h | 126 +++++
>
>> include/dt-bindings/clock/axg-clkc.h | 72 +++
>
> This belongs in the binding patch.
>
is it Ok to keep it in this patch?
the initial idea to do this is to keep the commit bisectable..

> Otherwise,
>
> Acked-by: Rob Herring <robh@xxxxxxxxxx>
>
>
>> 6 files changed, 1156 insertions(+)
>> create mode 100644 drivers/clk/meson/axg.c
>> create mode 100644 drivers/clk/meson/axg.h
>> create mode 100644 include/dt-bindings/clock/axg-clkc.h
>
> .
>