Re: ALSA: nm256: Fine-tuning for three function implementations

From: Takashi Iwai
Date: Tue Nov 28 2017 - 13:35:23 EST


On Tue, 28 Nov 2017 18:15:34 +0100,
SF Markus Elfring wrote:
>
> >> Do you want that I point any other patch out which you could find
> >> easier to handle again?
> >
> > Only if they got tested and/or got reviewed by others.
>
> Would you find any of the following update suggestions trivial enough
> to integrate them?
>
> Examples:
> * ALSA: cs5530: Use common error handling code in snd_cs5530_probe()
> https://lkml.org/lkml/2017/11/18/266
> https://patchwork.kernel.org/patch/10064945/
> https://lkml.kernel.org/r/<a2cb6494-a01c-668a-cd9b-1a8428a0d4c9@xxxxxxxxxxxxxxxxxxxxx>

This is no trivial patch.

> * ASoC: dapm: Use kcalloc() in snd_soc_dapm_new_widgets()
> https://lkml.org/lkml/2017/8/10/425
> https://patchwork.kernel.org/patch/9893713/
> https://lkml.kernel.org/r/<62be9e32-1b8d-3980-7998-72f82c62a6fe@xxxxxxxxxxxxxxxxxxxxx>

This needs to go through Mark's ASoC tree.

> * ALSA: seq: Delete unnecessary checks in snd_seq_ioctl_query_subs()
> https://lkml.org/lkml/2017/1/24/293
> https://patchwork.kernel.org/patch/9534795/
> https://lkml.kernel.org/r/<39bc00c0-ffe7-851c-f329-e7d499f561be@xxxxxxxxxxxxxxxxxxxxx>

This is no trivial patch, either.


Takashi