Re: [PATCH 2/2] thunderbolt: Mask ring interrupt properly when polling starts

[Bernat, Yehezkel]

On Mon, 2017-11-27 at 14:48 +0300, Mika Westerberg wrote:
> When ring enters polling mode we are expected to mask the ring
> interrupt
> before the callback is called. However, the current code actually
> unmasks it probably because of a copy-paste mistake.
> 
> Mask the interrupt properly from now on.
> 
> Fixes: 4ffe722eefcb ("thunderbolt: Add polling mode for rings")
> Signed-off-by: Mika Westerberg <mika.westerberg@xxxxxxxxxxxxxxx>
> ---
> Âdrivers/thunderbolt/nhi.c | 2 +-
> Â1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/thunderbolt/nhi.c b/drivers/thunderbolt/nhi.c
> index 419a7a90bce0..f45bcbc63738 100644
> --- a/drivers/thunderbolt/nhi.c
> +++ b/drivers/thunderbolt/nhi.c
> @@ -339,7 +339,7 @@ static void __ring_interrupt(struct tb_ring
> *ring)
> Â		return;
> Â
> Â	if (ring->start_poll) {
> -		__ring_interrupt_mask(ring, false);
> +		__ring_interrupt_mask(ring, true);
> Â		ring->start_poll(ring->poll_data);
> Â	} else {
> Â		schedule_work(&ring->work);

Acked-by: Yehezkel Bernat <yehezkel.bernat@xxxxxxxxx>