Re: [PATCH] ntb: remove unneeded DRIVER_LICENSE #defines

From: Jon Mason
Date: Mon Nov 27 2017 - 11:15:31 EST


On Fri, Nov 17, 2017 at 9:53 AM, Philippe Ombredanne
<pombredanne@xxxxxxxx> wrote:
> On Fri, Nov 17, 2017 at 3:20 PM, Greg Kroah-Hartman
> <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
>> There is no need to #define the license of the driver, just put it in
>> the MODULE_LICENSE() line directly as a text string.
>>
>> This allows tools that check that the module license matches the source
>> code license to work properly, as there is no need to unwind the
>> unneeded dereference, especially when the string is defined just a few
>> lines above the usage of it.
>>
>> Cc: Jon Mason <jdmason@xxxxxxxx>
>> Cc: Dave Jiang <dave.jiang@xxxxxxxxx>
>> Cc: Allen Hubbe <Allen.Hubbe@xxxxxxx>
>> Cc: Gary R Hook <gary.hook@xxxxxxx>
>> Cc: Serge Semin <fancer.lancer@xxxxxxxxx>
>> Reported-by: Philippe Ombredanne <pombredanne@xxxxxxxx>
>> Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
>
>
> Reviewed-by: Philippe Ombredanne <pombredanne@xxxxxxxx>

Applied to my ntb-next branch.

Thanks,
Jon

> --
> Cordially
> Philippe Ombredanne