Re: [PATCH 12/43] x86/espfix/64: Stop assuming that pt_regs is on the entry stack

From: Ingo Molnar
Date: Mon Nov 27 2017 - 04:19:25 EST



* Borislav Petkov <bp@xxxxxxxxx> wrote:

> On Sun, Nov 26, 2017 at 03:05:33PM +0100, Ingo Molnar wrote:
> > > https://git.kernel.org/pub/scm/linux/kernel/git/luto/linux.git/commit/?h=x86/entry_stack&id=6510485d026abdd144d170b1bc8508327acb5648
> >
> > I have added Boris's reviewed-by tag:
> >
> > Reviewed-by: Borislav Petkov <bp@xxxxxxx>
> >
> > which I suspect applies now?
>
> Almost, looking at the patch at that URL, there's a trailing "modify" in the
> comment:
>
> + * we land directly at the #GP(0) vector with the stack already
> + * set up according to its expectations.modify
> ^^^^^^
> which you can amend-remove.

Oops - fixed.

> Other than that, it looks good!

Thanks!

Ingo