Re: [PATCH v2] checkpatch: Add a warning for log messages that don't end in a new line

From: Julia Lawall
Date: Mon Nov 27 2017 - 01:42:54 EST




On Mon, 27 Nov 2017, Julia Lawall wrote:

>
>
> On Sun, 26 Nov 2017, Joe Perches wrote:
>
> > On Sun, 2017-11-26 at 19:17 +0100, Julia Lawall wrote:
> > > I just assume that a printk that has no KERN_ is adding a
> > > newline, which is my understanding of Joe's comment.
> >
> > More precisely:
> >
> > Any printk without an initial KERN_CONT prepends a newline
> > if the last printk content char emitted that is not part
> > of a printk timestamp/header was not a newline.
>
> Ah, I misunderstood. I thought it was any printk that has no KERN
> indicator at all. That I can fix.

Although I guess that in that case the whole exercise is pointless?
Because every print will at runtime be followed by another print, which
will add either the newline or a continuation.

julia