Re: [PATCH v7 06/13] slimbus: Add messaging APIs to slimbus framework

From: Vinod Koul
Date: Mon Nov 27 2017 - 00:52:47 EST


On Mon, Nov 20, 2017 at 06:47:52AM +0000, Srinivas Kandagatla wrote:

> >>+ * -ENOTCONN: If the transmitted message was not ACKed by destination
> >>+ * device.
> >
> >I am preferring ENODATA in SDW for this case, as Slaves didnt respond or
> >ACK.
> Isn't that a timeout error then.
>
> ENODATA is for "No data available", reporting ENODATA would be misleading.

Do you get a explict NACK or no response for this

>
> >
> >ENOTCONN is defined as /* Transport endpoint is not connected */ which is
> >not the case here, connected yes but not responded.
>
> Code as it is would not return this, so i will be deleting ENOTCONN from
> kernel doc.

ok

--
~Vinod