RE: [PATCH v3] staging: fsl-mc: use 32bits to support 64K size mc-portals

From: Bharat Bhushan
Date: Fri Nov 24 2017 - 11:00:52 EST


Hi Greg,

> -----Original Message-----
> From: gregkh@xxxxxxxxxxxxxxxxxxx [mailto:gregkh@xxxxxxxxxxxxxxxxxxx]
> Sent: Friday, November 24, 2017 9:29 PM
> To: Laurentiu Tudor <laurentiu.tudor@xxxxxxx>
> Cc: Bharat Bhushan <bharat.bhushan@xxxxxxx>; Ruxandra Ioana Radulescu
> <ruxandra.radulescu@xxxxxxx>; devel@xxxxxxxxxxxxxxxxxxxx;
> stuyoder@xxxxxxxxx; Roy Pledge <roy.pledge@xxxxxxx>; linux-
> kernel@xxxxxxxxxxxxxxx; Leo Li <leoyang.li@xxxxxxx>; Bogdan Purcareata
> <bogdan.purcareata@xxxxxxx>; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
> Subject: Re: [PATCH v3] staging: fsl-mc: use 32bits to support 64K size mc-
> portals
>
> On Wed, Nov 22, 2017 at 10:49:50AM +0000, Laurentiu Tudor wrote:
> >
> >
> > On 11/22/2017 09:48 AM, Bharat Bhushan wrote:
> > > As per APIs each mc-portal is of 64K size while currently 16bits
> > > (type u16) is used to store size of mc-portal.
> > > In these cases upper bit of portal size gets truncated.
> > >
> > > Signed-off-by: Bharat Bhushan <Bharat.Bhushan@xxxxxxx>
> > > ---
> >
> > Ok, so just to clarify this fixes the case where size is equal (or
> > maybe larger in the future) to 0x10000.
>
> Is this something that can happen today? Is this needed in 4.14 to fix a
> problem people are having and need to be backported to stable, or can it
> wait until 4.15?

We can wait for 4.15 and no need to backport.

Thanks
-Bharat

>
> thanks,
>
> greg k-h