RE: [PATCH AUTOSEL for 4.9 37/54] RDMA/qedr: Fix RDMA CM loopback

From: Amrani, Ram
Date: Thu Nov 23 2017 - 01:11:45 EST


> From: Ram Amrani <Ram.Amrani@xxxxxxxxxx>
>
> [ Upstream commit af2b14b8b8ae21b0047a52c767ac8b44f435a280 ]
>
> The loopback logic in RDMA CM packets compares Ethernet addresses and
> was accidently inverse.
>
> Signed-off-by: Ram Amrani <Ram.Amrani@xxxxxxxxxx>
> Signed-off-by: Ariel Elior <Ariel.Elior@xxxxxxxxxx>
> Signed-off-by: Doug Ledford <dledford@xxxxxxxxxx>
> Signed-off-by: Sasha Levin <alexander.levin@xxxxxxxxxxx>
> ---
> drivers/infiniband/hw/qedr/qedr_cm.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/infiniband/hw/qedr/qedr_cm.c b/drivers/infiniband/hw/qedr/qedr_cm.c
> index 63890ebb72bd..eccf7039aaca 100644
> --- a/drivers/infiniband/hw/qedr/qedr_cm.c
> +++ b/drivers/infiniband/hw/qedr/qedr_cm.c
> @@ -404,9 +404,9 @@ static inline int qedr_gsi_build_packet(struct qedr_dev *dev,
> }
>
> if (ether_addr_equal(udh.eth.smac_h, udh.eth.dmac_h))
> - packet->tx_dest = QED_ROCE_LL2_TX_DEST_NW;
> - else
> packet->tx_dest = QED_ROCE_LL2_TX_DEST_LB;
> + else
> + packet->tx_dest = QED_ROCE_LL2_TX_DEST_NW;
>
> packet->roce_mode = roce_mode;
> memcpy(packet->header.vaddr, ud_header_buffer, header_size);
> --
> 2.11.0


Thanks!

Acked-by: Ram Amrani <Ram.Amrani@xxxxxxxxxx>