Re: [PATCH 3.16 105/133] mm/vmstat.c: fix wrong comment

From: Vlastimil Babka
Date: Wed Nov 22 2017 - 02:41:25 EST


On 11/22/2017 02:58 AM, Ben Hutchings wrote:
> 3.16.51-rc1 review patch. If anyone has any objections, please let me know.

I don't really care much in the end, but is "fix wrong comment" really a
stable patch material these days? :)

> ------------------
>
> From: SeongJae Park <sj38.park@xxxxxxxxx>
>
> commit f113e64121ba9f4791332248b315d9f57ee33a6b upstream.
>
> Comment for pagetypeinfo_showblockcount() is mistakenly duplicated from
> pagetypeinfo_show_free()'s comment. This commit fixes it.
>
> Link: http://lkml.kernel.org/r/20170809185816.11244-1-sj38.park@xxxxxxxxx
> Fixes: 467c996c1e19 ("Print out statistics in relation to fragmentation avoidance to /proc/pagetypeinfo")
> Signed-off-by: SeongJae Park <sj38.park@xxxxxxxxx>
> Cc: Michal Hocko <mhocko@xxxxxxxxxx>
> Cc: Vlastimil Babka <vbabka@xxxxxxx>
> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
> Signed-off-by: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>
> Signed-off-by: Ben Hutchings <ben@xxxxxxxxxxxxxxx>
> ---
> mm/vmstat.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- a/mm/vmstat.c
> +++ b/mm/vmstat.c
> @@ -975,7 +975,7 @@ static void pagetypeinfo_showblockcount_
> seq_putc(m, '\n');
> }
>
> -/* Print out the free pages at each order for each migratetype */
> +/* Print out the number of pageblocks for each migratetype */
> static int pagetypeinfo_showblockcount(struct seq_file *m, void *arg)
> {
> int mtype;
>