Re: kernel_read() changed from v4.13 to v4.14

From: Cong Wang
Date: Tue Nov 21 2017 - 16:20:54 EST


On Tue, Nov 21, 2017 at 1:05 PM, Zytaruk, Kelly <Kelly.Zytaruk@xxxxxxx> wrote:
> I noticed that the parameter ordering to kernel_read() changed from Linux kernel v4.13 to v4.14 when the function was moved into fs/read_write.c from exec.c
>
> 4.13.15 - int kernel_read(struct file *file, loff_t offset, char *addr, unsigned long count)
>
> 4.14.1 - ssize_t kernel_read(struct file *file, void *buf, size_t count, loff_t *pos)
>
> I am still on the learning curve so I would like to understand why this was done instead of keeping the same ordering.


My guess is that it matches the syscall read() more closely.