Re: [PATCH v1 3/9] perf util: Reconstruct rblist for supporting per-thread shadow stats

From: Jiri Olsa
Date: Tue Nov 21 2017 - 10:17:23 EST


On Mon, Nov 20, 2017 at 10:43:38PM +0800, Jin Yao wrote:
> In current stat-shadow.c, the rblist deleting is ignored.
>
> The patch reconstructs the codes of rblist init/free, and adds
> the implementation to node_delete method of rblist.
>
> This patch also does:
>
> 1. Add the ctx/type/stat into rbtree keys because we will
> use this rbtree to maintain shadow metrics to replace original
> a couple of static arrays for supporting per-thread shadow stats.
>
> 2. Create a static runtime_stat variable 'rt_stat' which
> will log the shadow metrics by default.

please make that separate patches then,
one patch - one logical change

thanks,
jirka