RE: [PATCH v1 0/5] platform/x86: intel_telemetry: Fix counters and formatting

From: Chakravarty, Souvik K
Date: Sun Nov 19 2017 - 22:12:36 EST


On Fri, Nov 17, 2017 at 7:07 PM, Andy Shevchenko <andy.shevchenko@xxxxxxxxx> wrote:
> On Thu, Nov 16, 2017 at 12:18 PM, Souvik Kumar Chakravarty
> <souvik.k.chakravarty@xxxxxxxxx> wrote:
> > This patchset fixes
> > https://bugzilla.kernel.org/show_bug.cgi?id=197833, and other issues
> > related to telemetry counters. It also cleans up formatting and removes
> redundanant code.
> >
> > It is rebased on top of the TESTING branch.
>
> Overall looks not so bad, please address my comments.

Thanks for the comments Andy. I will re-spin another set.
>
> >
> > Souvik Kumar Chakravarty (5):
> > platform/x86: intel_pmc_ipc: Fix register names
> > platform/x86: intel_telemetry: Fix suspend stats
> > platform/x86: intel_telemetry: Fix local variables
> > platform/x86: intel_telemetry: Remove redundancies
> > platform/x86: intel_telemetry: Improve S0ix logs
> >
> > arch/x86/include/asm/intel_pmc_ipc.h | 10 ++-
> > drivers/platform/x86/intel_pmc_ipc.c | 4 +-
> > drivers/platform/x86/intel_telemetry_debugfs.c | 101
> > +++++++++++++------------
> > 3 files changed, 59 insertions(+), 56 deletions(-)
> >
> > --
> > 2.7.4
> >
>
>
>
> --
> With Best Regards,
> Andy Shevchenko