Re: [PATCH] ALSA: via82xx: Use common error handling code in snd_via82xx_create()

From: SF Markus Elfring
Date: Sun Nov 19 2017 - 01:38:43 EST


>> @@ -1153,6 +1150,14 @@ static int snd_via82xx_create(struct snd_card *card,
>>
>> *r_via = chip;
>> return 0;
>> +
>> +disable_device:
>> + pci_disable_device(pci);
>> + goto exit;
>> +free_chip:
>> + snd_via82xx_free(chip);
>> +exit:
>> + return err;
>
> Doubly goto doesn't look like an improvement.

Would you like to integrate another software update with the statement
âreturn err;â instead of âgoto exit;â at this place?

Regards,
Markus