Re: [PATCH v2 net-next] net/tcp: trace all TCP/IP state transition with tcp_set_state tracepoint

From: David Miller
Date: Sat Nov 18 2017 - 22:41:21 EST


From: Yafang Shao <laoar.shao@xxxxxxxxx>
Date: Sat, 18 Nov 2017 15:32:36 +0000

> The TCP/IP transition from TCP_LISTEN to TCP_SYN_RECV and some other
> transitions are not traced with tcp_set_state tracepoint.
>
> In order to trace the whole tcp lifespans, two helpers are introduced,
> void __tcp_set_state(struct sock *sk, int state)
> void __sk_state_store(struct sock *sk, int newstate)
>
> When do TCP/IP state transition, we should use these two helpers or use
> tcp_set_state() other than assigning a value to sk_state directly.
>
> Signed-off-by: Yafang Shao <laoar.shao@xxxxxxxxx>

Please resubmit this when the net-next tree opens back up as it is
closed right now.

Thank you.