Re: [PATCH v3 1/4] dt-bindings: iio: at91-sama5d2_adc: add optional dma property

From: Jonathan Cameron
Date: Sat Nov 18 2017 - 11:08:08 EST


On Wed, 15 Nov 2017 09:27:46 -0600
Rob Herring <robh@xxxxxxxxxx> wrote:

> On Wed, Nov 15, 2017 at 02:56:45PM +0200, Eugen Hristev wrote:
> > Added property for DMA configuration of the device.
> >
> > Signed-off-by: Eugen Hristev <eugen.hristev@xxxxxxxxxxxxx>
> > ---
> > Changes in v3:
> > None, but we discussed on the ML about whether we should have "dma-names"
> > present in the binding even if it's only one.
> > The helpers in the kernel to retrieve the channel info rely on the
> > presence of this property, so I am resending the patch based on this.
> > If another solution is better, please advise and I can try it and
> > resend the patch.
>
> Really the kernel APIs should accept a NULL name and return the DMA
> channel when there is only one. This is how the clk_get API works for
> example.
>
> > Documentation/devicetree/bindings/iio/adc/at91-sama5d2_adc.txt | 7 +++++++
> > 1 file changed, 7 insertions(+)
>
> In any case, not really a big deal.
>
> Acked-by: Rob Herring <robh@xxxxxxxxxx>
Applied to the togreg branch of iio.git and pushed out as testing.

Thanks,

Jonathan
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html