Re: [PATCH] video: fbdev: sm501fb: fix potential null pointer dereference on fbi

From: Bartlomiej Zolnierkiewicz
Date: Fri Nov 17 2017 - 11:03:51 EST


On Friday, November 10, 2017 05:32:31 PM Colin King wrote:
> From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
>
> The pointer fbi is dereferenced with par = fbi->par before there is a
> null check on fbi, hence there is a potential null pointer dereference
> on a null par. Fix this by moving the dereference after the null
> pointer check.
>
> Detected by CoverityScan, CID#1461301 ("Dereference before null check")
>
> Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>

Patch queued for 4.15, thanks.

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics