Re: [PATCH 6/6] media: usb: add SPDX identifiers to some code I wrote

From: Philippe Ombredanne
Date: Fri Nov 17 2017 - 10:10:06 EST


On Fri, Nov 17, 2017 at 4:01 PM, Mauro Carvalho Chehab
<mchehab@xxxxxxxxxxxxxxxx> wrote:
> Em Fri, 17 Nov 2017 12:54:15 +0100
> Philippe Ombredanne <pombredanne@xxxxxxxx> escreveu:
>
>> On Fri, Nov 17, 2017 at 11:21 AM, Mauro Carvalho Chehab
>> <mchehab@xxxxxxxxxxxxxxxx> wrote:
>> > As we're now using SPDX identifiers, on several
>> > media drivers I wrote, add the proper SPDX, identifying
>> > the license I meant.
>> >
>> > As we're now using the short license, it doesn't make sense to
>> > keep the original license text.
>> >
>> > Also, fix MODULE_LICENSE to properly identify GPL v2.
>> >
>> > Signed-off-by: Mauro Carvalho Chehab <mchehab@xxxxxxxxxxxxxxxx>
>>
>> Mauro,
>> Thanks ++ .... I can now get rid of a special license detection rule I
>> had added for the specific language of your notices in the
>> scancode-toolkit!
>
> :-)
>
> Yeah, I was too lazy to copy the usual GPL preamble on those
> drivers ;-)

I guess I built a lazyness checker with scancode to keep you check then ;)
But FWIW you are not alone there and at least your notices are/were
consistent across files ... there are still several hundred variations
of GPL notices in the kernel each with subtle or byzantine changes.

Some of them are rather funny like Evgeniy's thermal code being under
the "therms" of the GPL [1]

CC: Evgeniy Polyakov <zbr@xxxxxxxxxxx>

[1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/w1/slaves/w1_therm.c?h=v4.14-rc8#n8
--
Cordially
Philippe Ombredanne