RE: [PATCH v2 1/2] acpi/x86: Fix improper handling of SCI INT for platforms supporting only IOAPIC mode

From: Thomas Gleixner
Date: Thu Nov 16 2017 - 07:17:14 EST


On Thu, 16 Nov 2017, Sajjan, Vikas C wrote:
> -----Original Message-----
> From: Thomas Gleixner [mailto:tglx@xxxxxxxxxxxxx]
> Sent: Thursday, November 16, 2017 4:35 PM
> To: Sajjan, Vikas C <vikas.cha.sajjan@xxxxxxx>
> Cc: rjw@xxxxxxxxxxxxx; rafael.j.wysocki@xxxxxxxxx; linux-pm@xxxxxxxxxxxxxxx; linux-acpi@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; kkamagui@xxxxxxxxx; mingo@xxxxxxxxxx; Lakshminarasimha, Sunil Vishwanathpur <sunil.vl@xxxxxxx>; Attar, Abdul Lateef <abdul-lateef.attar@xxxxxxx>
> Subject: Re: [PATCH v2 1/2] acpi/x86: Fix improper handling of SCI INT for platforms supporting only IOAPIC mode

Can you please fix your mail client to not pointlessly copy the full mail
header?

On Thu, 16 Nov 2017, Thomas Gleixner wrote:

is enough. The rest is in the real mail headers already.

> On Thu, 16 Nov 2017, Vikas C Sajjan wrote:
> > Signed-off-by: Vikas C Sajjan <vikas.cha.sajjan@xxxxxxx>
> > Signed-off-by: Sunil V L <sunil.vl@xxxxxxx>
> > Signed-off-by: Abdul Lateef Attar <abdul-lateef.attar@xxxxxxx>
>
> This Signed-off-by chain is broken. It says:
>
> Vikas wrote the patch and handed it to Sunil
> Sunil handed it to Abdul
> Abdul sent it to lkml
>
> Which is obviously not the case.

> 3 of us worked on it, hence I had put all the 3 "Signed-off-by". Are you
> suggesting to call-out who did what. Is that what you mean, when you say
> "Signed-off-by chain is broken".

No. As I explained above. The Signed-off-by is a chain. The first one is
from the author. The following ones are from people who handled,
transported or applied the patch.

See Documentation/process/submitting-patches.rst the chapter:

Developer's Certificate of Origin 1.1

for further clarification.

Unfortunately we have no canonical way to express joint develoment, but we
have used non formal tags for that, like

Co-developed-by:

which give credits to the people who were involved in the development.

Thanks,

tglx