Re: [PATCH v3 1/2] net: phy: leds: Refactor "no link" handler into a separate function

From: David Miller
Date: Tue Nov 07 2017 - 20:25:24 EST


From: "Maciej S. Szmigiero" <mail@xxxxxxxxxxxxxxxxxxxxx>
Date: Thu, 2 Nov 2017 00:48:45 +0100

> Currently, phy_led_trigger_change_speed() is handling a "no link" condition
> like it was some kind of an error (using "goto" to a code at the function
> end).
>
> However, having no link at PHY is an ordinary operational state, so let's
> handle it in an appropriately named separate function so it is more obvious
> what the code is doing.
>
> Signed-off-by: Maciej S. Szmigiero <mail@xxxxxxxxxxxxxxxxxxxxx>

Applied.