Re: [PATCH v2] IB/ocrdma_hw: remove unnecessary code in ocrdma_mbx_dealloc_lkey

[Leon Romanovsky]

On Tue, Nov 07, 2017 at 08:56:37AM -0600, Gustavo A. R. Silva wrote:
>
> Quoting Leon Romanovsky <leon@xxxxxxxxxx>:
>
> > On Tue, Nov 07, 2017 at 08:45:17AM -0600, Gustavo A. R. Silva wrote:
> > > Check on return value and goto label mbx_err are unnecessary.
> > >
> > > Addresses-Coverity-ID: 1268780
> > > Signed-off-by: Gustavo A. R. Silva <garsilva@xxxxxxxxxxxxxx>
> > > Reviewed-by: Yuval Shaia <yuval.shaia@xxxxxxxxxx>
> > > ---
> > > Changes in v2:
> > >  Remove assignment from "int status = -ENOMEM" as suggested by Leon
> > > Romanovsky.
> > >
> > >  drivers/infiniband/hw/ocrdma/ocrdma_hw.c | 6 ++----
> > >  1 file changed, 2 insertions(+), 4 deletions(-)
> >
> > Please use git send-email to send patches and not reply to the conversation.
> >
>
> I'm using mutt.
> What would be the advantage of using git send-email in this case?

New mail headers, so it won't appear as Reply-To and will be presented
correctly in mutt's threaded mode.

You can do it with mutt too.

>
> > Thanks,
> > Reviewed-by: Leon Romanovsky <leonro@xxxxxxxxxxxx>
>
> Thank you
> --
> Gustavo A. R. Silva
>
>
>
>
>

Attachment: signature.asc
Description: PGP signature