Re: [PATCH] dm-crypt, dm-integrity: allow unaligned bv_offset

From: Milan Broz
Date: Tue Nov 07 2017 - 03:31:10 EST


On 11/07/2017 09:13 AM, Bruno PrÃmont wrote:
>> Signed-off-by: Mikulas Patocka <mpatocka@xxxxxxxxxx>
>> Cc: stable@xxxxxxxxxxxxxxx # v4.12+
>> Fixes: 8f0009a22517 ("dm crypt: optionally support larger encryption sector size")
>> Fixes: 7eada909bfd7 ("dm: add integrity target")
>
> Reported-by: Bruno PrÃmont <bonbons@xxxxxxxxxx>
> Tested-by: Bruno PrÃmont <bonbons@xxxxxxxxxx>
>
> Successfully tested on 4.12.14, 4.13.11 and 4.14-rc8+ (e4880bc5dfb1).

Thanks!

(That alignment check was added after our discussion - we wanted
to have dm-crypt and dm-integrity to check the same thing, just to trigger
possible data corruption, but obviously it was incorrect check.)

It must go to stable well, I think there are possibly more situations
we broke for dm-crypt by this.

Reviewed-by: Milan Broz <gmazyland@xxxxxxxxx>

m.