Re: [PATCH] ieee802154: mrf24j40: fix incorrect mask in mrf24j40_stop

[Alan Ott]

On 11/06/2017 06:13 AM, Stefan Schmidt wrote:
> Hello Alan.
>
> On 10/31/2017 07:31 AM, Gustavo A. R. Silva wrote:
> > It seems that this is a copy/paste error and the proper bit masking is:
> > BIT_TXNIE | BIT_RXIE
> >
> > This issue was detected with the help of Coccinelle.
> >
> > Reported-by: Julia Lawall <julia.lawall@xxxxxxx>
> > Signed-off-by: Gustavo A. R. Silva <garsilva@xxxxxxxxxxxxxx>
> > Fixes: 7d840545e5b9 ("mrf24j40: replace magic numbers")
> > ---
> >  drivers/net/ieee802154/mrf24j40.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/net/ieee802154/mrf24j40.c b/drivers/net/ieee802154/mrf24j40.c
> > index ee7084b..cf4788d 100644
> > --- a/drivers/net/ieee802154/mrf24j40.c
> > +++ b/drivers/net/ieee802154/mrf24j40.c
> > @@ -635,7 +635,7 @@ static void mrf24j40_stop(struct ieee802154_hw *hw)
> >
> >  	/* Set TXNIE and RXIE. Disable Interrupts */
> >  	regmap_update_bits(devrec->regmap_short, REG_INTCON,
> > -			   BIT_TXNIE | BIT_TXNIE, BIT_TXNIE | BIT_TXNIE);
> > +			   BIT_TXNIE | BIT_RXIE, BIT_TXNIE | BIT_RXIE);
> >  }
> >
> >  static int mrf24j40_set_channel(struct ieee802154_hw *hw, u8 page, u8 channel)
>
> Could you review this and give me your ack when you are happy so I can apply it to my tree?

Acked-by: Alan Ott <alan@xxxxxxxxxxx>