Re: [PATCH] netfilter: ip6_tables: remove redundant assignment to e

From: Pablo Neira Ayuso
Date: Mon Nov 06 2017 - 08:19:10 EST


On Tue, Oct 17, 2017 at 01:02:00PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
>
> The assignment to variable e is redundant since the same assignment
> occurs just a few lines later, hence it can be removed. Cleans up
> clang warning: warning: Value stored to 'e' is never read

Seems like net/ipv4/netfilter/ip_tables.c also has exactly the same
redundant assignment, see mark_source_chains() there.

If we can fix this all iptables spots in one go, the best. Please,
also check arp_tables and ebtables.

Thanks!